[WS-2650]: Sign-in popup banner implementation#14082
Draft
SantaZena wants to merge 12 commits into
Draft
Conversation
…sign-in-popup-banner-implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: https://bbc.atlassian.net/browse/WS-2650
Summary
Adds a sign-in popup modal that surfaces the account promotional banner in a focus-trapped, dismissible dialog with responsive imagery.
Code changes
AccountSignInModalcomponent with backdrop, focus trapping and Escape/click-to-close handling.useTrappedFocushook to keep keyboard focus within the modal.styleOverridesprop toPromotionalBannerso consumers can override slot styles, replacing thepromo-banner-*class hooks.AccountPromotionalBannerand render breakpoint-specific sign-in images via CSS variables.Testing
yarn devand open a hindi article (e.g./hindi/articles/c0469479x9xo) (The user should not be signed in).Useful Links
Figma design: https://www.figma.com/design/8xqdz6WAYt2QpcLguVBCFz/WS-Sign-In-prompt?node-id=117-4210&p=f&t=bLX9drCEGAV2HoZj-0